Skip to content

Allow advanced padding to position video vertically#681

Draft
surim0n wants to merge 1 commit into
webadderallorg:mainfrom
surim0n:codex/true-vertical-padding-position
Draft

Allow advanced padding to position video vertically#681
surim0n wants to merge 1 commit into
webadderallorg:mainfrom
surim0n:codex/true-vertical-padding-position

Conversation

@surim0n

@surim0n surim0n commented Jun 15, 2026

Copy link
Copy Markdown

Summary

  • Extends advanced Top/Bottom padding to 250% while keeping linked padding on the original 0-100 range.
  • Uses the extra vertical range as positional travel so Bottom=250 can pin the screen recording to the top edge and Top=250 can pin it to the bottom edge.
  • Preserves extended advanced padding values when projects are loaded and adds focused layout/persistence tests.

Verification

  • npx vitest --run src/components/video-editor/videoPlayback/layoutUtils.test.ts src/components/video-editor/projectPersistence.test.ts
  • npx biome check src/components/video-editor/projectPersistence.ts src/components/video-editor/projectPersistence.test.ts src/components/video-editor/types.ts src/components/video-editor/videoPlayback/layoutUtils.ts src/components/video-editor/videoPlayback/layoutUtils.test.ts

Notes

  • npm run lint still fails on existing unrelated formatting/import diagnostics outside this change.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 20d69bf1-22ad-4cbf-8d28-f183a9b3327b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant